Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxing on MacOS: considering the possibility that TMPDIR in unset #3597

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@herbelin
Copy link
Contributor

herbelin commented Oct 10, 2018

This is a PR to address #3576 (see discussion there).

I added a test which presumably makes that the fix works on both linux and MacOS X (on MacOS X, we use getconf to get the per-user temporary directory).

@rjbou clarified that the file sandbox_exec.sh is actually only for MacOS X. I updated the PR to simplify the comment explaining the situation.

Tested on MacOS 10.11.1 both with TMPDIR set and unset.

Sandboxing on MacOS: considering the possibility that TMPDIR in unset
We then use `getconf` to get the per-user temporary directory.

@herbelin herbelin force-pushed the herbelin:master+fix-sandbox-TMPDIR-unset-macosx branch from dc72443 to a57d1b4 Oct 10, 2018

@rjbou rjbou merged commit bdeecda into ocaml:master Oct 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rjbou

This comment has been minimized.

Copy link
Collaborator

rjbou commented Oct 17, 2018

Thanks!

rjbou added a commit to rjbou/opam that referenced this pull request Feb 20, 2019

Sandboxing on MacOS: considering the possibility that TMPDIR in unset (
…ocaml#3597)

We then use `getconf` to get the per-user temporary directory.

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

Sandboxing on MacOS: considering the possibility that TMPDIR in unset (
…ocaml#3597)

We then use `getconf` to get the per-user temporary directory.

@rjbou rjbou referenced this pull request Mar 27, 2019

Merged

2.0.4 backported commits #3805

@rjbou rjbou added this to the 2.0.4 milestone Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.