Sandboxing on MacOS: considering the possibility that TMPDIR in unset #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We then use `getconf` to get the per-user temporary directory.
herbelin
force-pushed
the
master+fix-sandbox-TMPDIR-unset-macosx
branch
from
dc72443
to
a57d1b4
Compare
|
Thanks! |
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Feb 20, 2019
…ocaml#3597) We then use `getconf` to get the per-user temporary directory.
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Mar 27, 2019
…ocaml#3597) We then use `getconf` to get the per-user temporary directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to address #3576 (see discussion there).
I added a test which presumably makes that the fix works on both linux and MacOS X (on MacOS X, we usegetconfto get the per-user temporary directory).@rjbou clarified that the file
sandbox_exec.shis actually only for MacOS X. I updated the PR to simplify the comment explaining the situation.Tested on MacOS 10.11.1 both with TMPDIR set and unset.