Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in man pages #3706

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@dra27
Copy link
Contributor

commented Dec 14, 2018

Same as #3700, but on 2.0 branch and with a CI test for the future.

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

(assuming you're happy with it, 7fd8531 needs to go on master too)

done
$(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1
$(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1 2>> man/err
# Dune doesn't (yet) support --no-print-directory

This comment has been minimized.

Copy link
@avsm

avsm Dec 16, 2018

Member
Suggested change
# Dune doesn't (yet) support --no-print-directory
# TODO Dune will support --no-print-directory in 1.7.0 and higher

This comment has been minimized.

Copy link
@dra27

dra27 Dec 16, 2018

Author Contributor

🙂 At the time I pushed this branch, I had only just opened the PR in Dune and didn't want to presume until it was merged. This comment could be changed on master, but I don't think we want to constrain Dune to >= 1.7.0 on the 2.0 branch

This comment has been minimized.

Copy link
@avsm

avsm Dec 16, 2018

Member

Makes sense!

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 27, 2019

Closing the PR,

  • 626baf5 is 2.0.3 release
  • 7fd8531 will be in 2.0.4 release (cf. referenced pr)
    Thanks!

@rjbou rjbou closed this Mar 27, 2019

@rjbou rjbou added this to the 2.0.4 milestone Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.