Fix typo in man pages #3706
Closed
Fix typo in man pages #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(assuming you're happy with it, 7fd8531 needs to go on master too) |
avsm
reviewed
Dec 16, 2018
| done | ||
| $(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1 | ||
| $(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1 2>> man/err | ||
| # Dune doesn't (yet) support --no-print-directory |
There was a problem hiding this comment.
Suggested change
| # Dune doesn't (yet) support --no-print-directory | |
| # TODO Dune will support --no-print-directory in 1.7.0 and higher |
There was a problem hiding this comment.
🙂 At the time I pushed this branch, I had only just opened the PR in Dune and didn't want to presume until it was merged. This comment could be changed on master, but I don't think we want to constrain Dune to >= 1.7.0 on the 2.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3700, but on 2.0 branch and with a CI test for the future.