Set core.autocrlf and core.eol for Git remotes #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that Git always disables text file line-ending normalisation when cloning changes from a Git remote.
Separate (still to be done) work on the
OpamLocaldriver,opam admin, andopam lintcode will ensure that hashes for text files are always initially computed using the repository normalisation. This differs from the approach of previous PRs which potentially hashed two versions of the file by determining from the git if the file needs transforming prior to the single hash being computed. The only time this transformation comes into play is if a Local (i.e. rsync) remote of a Git clone is added on a platform withcore.autocrlfset totrue(i.e. if you are working in a Git clone of a remote withcore.autocrlfset totrue)