Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat os-family=ubuntu as os-family=debian #4441

Merged
merged 3 commits into from Nov 26, 2020
Merged

Conversation

alan-j-hu
Copy link
Contributor

At least on Linux Mint 20, the value of os-family is ubuntu. This caused opam depext to fail for me, as ubuntu is not one of the handled cases. This PR treats os-family=ubuntu as os-family=debian.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rjbou rjbou added this to PR in Progress in Opam 2.1.x via automation Nov 19, 2020
@rjbou rjbou added this to the 2.1.0~beta4 milestone Nov 19, 2020
@rjbou rjbou moved this from PR in Progress to PR Finalised in Opam 2.1.x Nov 23, 2020
@rjbou rjbou merged commit 0f9d3c9 into ocaml:master Nov 26, 2020
Opam 2.1.x automation moved this from PR Finalised to Done Nov 26, 2020
@rjbou
Copy link
Collaborator

rjbou commented Nov 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.1.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants