Don't connect stdin to sub-processes #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for the download command, I remember trying that to prevent |
|
Indeed - cross-referencing #4447. |
On Windows, default to not forwarding stdin (as it attaches the Console). Also explicitly don't connect stdin for the download command in OpamDownload or for the cygpath wrapper in OpamSystem.
rjbou
force-pushed
the
controlled-stdin
branch
from
02bd534
to
417b97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #3897. @AltGr agreed this was worth doing in #3897 (review), but it's too close to the 2.1 release for a change which isn't a critical part of that fix, so this can be merged post-2.1