Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete plugin links on root upgrade #4641

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Delete plugin links on root upgrade #4641

merged 4 commits into from
Apr 29, 2021

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Apr 21, 2021

This is the last part of #4619, which it turns out is a bit simpler and less dirty than I feared.

This Dockerfile demonstrates the problem:

FROM ocaml/opam:debian-ocaml-4.12
WORKDIR /src/test
RUN sudo chown opam /src/test
RUN opam pin add -n dose3 5.0.1-1 ; opam install dune dose3 opam-file-format mccs cmdliner ; opam install opam-dune-lint --deps-only
RUN opam exec -- dune init project foo
RUN echo > dune-project '(lang dune 2.8)\n(generate_opam_files true)(source (github foo/bar))(package (name foo))'
RUN opam exec -- dune build
WORKDIR /src
RUN sudo chown opam /src
#RUN git clone https://github.com/dra27/opam.git -b clear-plugins
#Comment out the line below and uncomment the line above to get the fix
RUN git clone https://github.com/ocaml/opam.git
WORKDIR /src/opam
RUN opam exec -- ./configure && opam exec -- make
WORKDIR /src/test
RUN opam install opam-state.2.0.8
RUN opam pin -yn opam-dune-lint 'https://github.com/ocurrent/opam-dune-lint.git#bf451c8cf2d4f2be3c7d979b613c79588b55a172'
RUN opam dune-lint
RUN sudo rm /usr/bin/opam && sudo cp /src/opam/opam /usr/bin/opam
RUN opam update
RUN opam dune-lint

and swapping the cloned repo over fixes the problem.

@dra27 dra27 added this to the 2.1.0~rc milestone Apr 21, 2021
@dra27 dra27 added this to PR in Progress in Opam 2.1.x via automation Apr 21, 2021
src/state/opamFormatUpgrade.ml Outdated Show resolved Hide resolved
@dra27 dra27 linked an issue Apr 21, 2021 that may be closed by this pull request
@dra27 dra27 force-pushed the clear-plugins branch 2 times, most recently from 3646fa2 to 37505f1 Compare April 22, 2021 17:11
@dra27 dra27 moved this from PR in Progress to PR To review in Opam 2.1.x Apr 28, 2021
Opam 2.1.x automation moved this from PR To review to PR Finalised Apr 29, 2021
@dra27 dra27 merged commit 471f767 into ocaml:master Apr 29, 2021
Opam 2.1.x automation moved this from PR Finalised to Done Apr 29, 2021
@dra27 dra27 deleted the clear-plugins branch April 29, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.1.x
  
Done
Development

Successfully merging this pull request may close these issues.

Invalidate plugins at root upgrade
2 participants