Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub OPAM* for variables added since 2.0 #4663

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

dra27
Copy link
Member

@dra27 dra27 commented May 14, 2021

Packages build with OPAMCLI=2.0. If the user sets an opam 2.1-specific environment variable, this is passed through to the package and will cause a warning to be displayed in the build log if the package calls opam.

All new environment variables are now scrubbed from the build environment.

@dra27 dra27 added this to the 2.1.0~rc milestone May 14, 2021
@dra27 dra27 requested a review from rjbou May 14, 2021 10:49
@dra27 dra27 added this to PR in Progress in Opam 2.1.x via automation May 14, 2021
@dra27 dra27 linked an issue May 14, 2021 that may be closed by this pull request
@dra27 dra27 moved this from PR in Progress to PR To review in Opam 2.1.x May 14, 2021
Opam 2.1.x automation moved this from PR To review to PR Finalised May 18, 2021
Packages build with OPAMCLI=2.0. If the user sets an opam 2.1-specific
environment variable, this is passed through to the package and will
cause a warning to be displayed in the build log if the package calls
opam.

All new environment variables are now scrubbed from the build
environment.
@dra27 dra27 merged commit 63e7a92 into ocaml:master May 24, 2021
Opam 2.1.x automation moved this from PR Finalised to Done May 24, 2021
@dra27 dra27 deleted the scrub-env-vars branch May 24, 2021 20:49
dra27 added a commit that referenced this pull request May 25, 2021
Parameter accidentally lost rebasing over #4668.
@dra27
Copy link
Member Author

dra27 commented May 25, 2021

I messed up the rebase on 21 May which the #4672 has now caught, but only the merge! Fixed by direct push in 5db90e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.1.x
  
Done
Development

Successfully merging this pull request may close these issues.

opam should scrub 2.1-specific environment variables in the build
2 participants