Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link archives in cache when several checksum are given #4696

Merged
merged 4 commits into from
Dec 18, 2021
Merged

Link archives in cache when several checksum are given #4696

merged 4 commits into from
Dec 18, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 2, 2021

Add link for other checksum on downloading, if possible. OpamSystem.link fallback is to copy, so for some systems, it can lead to multiples copies of a single archive/file.

@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jun 2, 2021
@rjbou rjbou removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jun 4, 2021
@rjbou rjbou added this to the 2.2.0~alpha milestone Jun 4, 2021
AltGr
AltGr reviewed Jun 14, 2021
View reviewed changes
master_changes.md Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate added this to PR in progress in Opam 2.2.0 via automation Jul 27, 2021
@rjbou rjbou moved this from PR in progress to PR finalised in Opam 2.2.0 Sep 1, 2021
kit-ty-kate
kit-ty-kate approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a new OpamHash.sort_best_to_weakest_hash_strength function to help making the code a bit clearer. Feel free to remove or rename the function if you think of a better one.

LGTM

@rjbou
Copy link
Collaborator Author

rjbou commented Dec 17, 2021

Thanks!

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit fac7453 into ocaml:master Dec 18, 2021
Opam 2.2.0 automation moved this from PR finalised to Done Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltGr AltGr AltGr left review comments

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rjbou @kit-ty-kate @AltGr