2.1.1 backported commits #4792
Merged
2.1.1 backported commits #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sandbox will attempt to mount the current working directory which may fail (and which we don't necessarily have any business doing).
Handle empty environment variable updates
The rpcndr.h header includes a typedef for byte which gets messed up when combined with using namespace std and C++17's byte type.
packages option with cli 2.0, and specific error message with cli 2.1
…tions and argument handling (avail on cli 2.0)
For environment variables which can be split (e.g. `PATH` on `:`), OpamEnv.unzip_to attempts to find the point in the variable at which a value was added. This is fine if a _single_ value was added, but fails if the addition was multiple values (for example, if a setenv instruction added two directories to `PATH` in one `+=`). This is fixed by first splitting the value being searched according to the same rule as the environmen variable and ensuring they all match in order.
When a package is installed, the switch environment is recomputed and written, but if the setenv fields referred to package variables just written to .config then these weren't available as the switch state didn't include the new config file. Subsequent calls to opam would then fix the issue as the .config file will have been loaded with the switch state.
repos, resulting on package not found with simple package argument
There's an ongoing issue in OCaml with the recent versions of the VS 2019 linker which need resolving. This should be reverted once that's done.
|
any timeline when the 2.1.1 release will happen? :) |
|
Later today 😁 Or possibly early next week... |
|
thanks for tagging the release :) could you submit the new packages to opam-repository? thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Pull requests
[Fix the cold target in presence of an older OCaml compiler version on macOS #4802 @kit-ty-kate - fix depexts/brew: Add support for casks and full-names #4801]
This fixes an issue on RHEL-based distributions where yum list used to detect
available and installed packages would wait for user input without showing
any output and/or fail in some cases [depexts: Disable the detection of available packages on RHEL-based distributions #4791 @kit-ty-kate - fixes remove -C option from yum #4790]
[Handle empty environment variable updates #4840 @dra27]
--packagesoption with cli 2.0, and a specific error message for cli 2.1[Fix cli regression on switch creation with packages #4853 @rjbou - fix CLI regression in
opam initin 2.1.0 #4843]added at once [Fix reverting additions to PATH-like variables #4861 @dra27]
[Ensure package variables are available at package install #4841 @dra27]
[Fix 'set-invariant pkg' whn 'pkg' is not in default repository #4869 @rjbou]