Make sure OpamListCommand.filter Depends_on recursive only returns a subset of base #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasseBlaauwbroek
force-pushed
the
recursive-inter-base
branch
from
d0c06bc
to
b11b523
Compare
|
Fixed in #4999 with some added performance improvements. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
OpamListCommand.filter ~base:packagesis supposed to only return a subset of the supplied packages. For recursive dependency search, this does not happen, however. As far as I can tell, this is not visible from the command line, because supplied patterns are filtered separately. However, for people who use Opam as a library, this is still unexpected behavior.