2.0.10 Backported commits #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For environment variables which can be split (e.g. `PATH` on `:`), OpamEnv.unzip_to attempts to find the point in the variable at which a value was added. This is fine if a _single_ value was added, but fails if the addition was multiple values (for example, if a setenv instruction added two directories to `PATH` in one `+=`). This is fixed by first splitting the value being searched according to the same rule as the environmen variable and ensuring they all match in order.
When a package is installed, the switch environment is recomputed and written, but if the setenv fields referred to package variables just written to .config then these weren't available as the switch state didn't include the new config file. Subsequent calls to opam would then fix the issue as the .config file will have been loaded with the switch state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Pull requests
added at once [Fix reverting additions to PATH-like variables #4861 @dra27]
[Ensure package variables are available at package install #4841 @dra27]