Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: don't display global message when `this-switch' is given #4899

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 8, 2021

fix #4889

@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 8, 2021
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Nov 8, 2021
@rjbou rjbou added the AREA: UI label Nov 8, 2021
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Nov 8, 2021
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully. Thanks!

| _ -> false)
List.exists (function
| `This_switch | `Current_switch | `Switch _ -> true
| _ -> false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we might want to get rid of those dangerous | _ -> ... patterns at some point in the future (i.e. enable -w 4 (fragile pattern matching))

Opam 2.2.0 automation moved this from PR to review to PR finalised Nov 9, 2021
@kit-ty-kate kit-ty-kate merged commit 29949fe into ocaml:master Nov 9, 2021
Opam 2.2.0 automation moved this from PR finalised to Done Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

opam repo add: silence warning when --this-switch is explicitly passed
2 participants