-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behaviour when stdout gets closed #4901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you add a one or two line cram test to the testsuite? |
Hmm I can try but we'll have to resort to using shell-pipes and that probably will break on Windows. @dra27 what do you think ? |
kit-ty-kate
reviewed
Nov 12, 2021
kit-ty-kate
added a commit
to kit-ty-kate/opam
that referenced
this pull request
Jan 22, 2022
Tests showing the bug added in #5022 |
kit-ty-kate
added a commit
to kit-ty-kate/opam
that referenced
this pull request
Jan 22, 2022
Will help merging ocaml#4901
kit-ty-kate
added a commit
to kit-ty-kate/opam
that referenced
this pull request
Jan 22, 2022
Will help merging ocaml#4901
kit-ty-kate
added
the
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
label
Jan 22, 2022
kit-ty-kate
added a commit
to kit-ty-kate/opam
that referenced
this pull request
Jan 25, 2022
Will help merging ocaml#4901
kit-ty-kate
removed
the
PR: QUEUED
Pending pull request, waiting for other work to be merged or closed
label
Jan 26, 2022
This needs to be applied for the tests to pass
|
Restore the sigpipe handler before exiting, to prevent the finaliser from crashing on flushes. Closes ocaml#4216
kit-ty-kate
approved these changes
Feb 2, 2022
Thanks for the rebase/test update @rjbou |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the sigpipe handler before exiting, to prevent the finaliser
from crashing on flushes.
Closes #4216: the behaviour on that example is now to exit with code
141, and without an error message.