Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserved format errors handling #4941

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Preserved format errors handling #4941

merged 2 commits into from
Mar 30, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Dec 1, 2021

see #4936 (comment)
fix #4936

TODO: add a test

@rjbou rjbou added KIND: BUG PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Dec 1, 2021
@rjbou rjbou added this to the 2.2.0~alpha milestone Dec 1, 2021
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Dec 1, 2021
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Dec 10, 2021
@rjbou rjbou removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Dec 14, 2021
@rjbou
Copy link
Collaborator Author

rjbou commented Dec 14, 2021

Split on two PR, as lock files has more fixes, see #4963

@rjbou rjbou changed the title Fix pinning with lock file: origin file and preserved format errors Preserved format errors handling Dec 14, 2021
@rjbou
Copy link
Collaborator Author

rjbou commented Mar 16, 2022

Hard to add a reftest on a function, it need some lib testing

@rjbou rjbou merged commit 9ab1590 into ocaml:master Mar 30, 2022
Opam 2.2.0 automation moved this from PR to review to Done Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Invalid_argument("String.sub / Bytes.sub") crash during pinning
1 participant