Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockf: catch Unix.EACCES #4948

Merged
merged 2 commits into from
Jan 21, 2022
Merged

lockf: catch Unix.EACCES #4948

merged 2 commits into from
Jan 21, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Dec 7, 2021

fix #4944

@rjbou rjbou added this to the 2.2.0~alpha milestone Dec 7, 2021
@rjbou rjbou requested a review from dra27 December 7, 2021 09:34
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Dec 7, 2021
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Dec 7, 2021
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://man7.org/linux/man-pages/man3/lockf.3.html this is indeed the right fix, even for Linux:

       EACCES or EAGAIN
              The file is locked and F_TLOCK or F_TEST was specified, or
              the operation is prohibited because the file has been
              memory-mapped by another process.

Opam 2.2.0 automation moved this from PR to review to PR finalised Dec 7, 2021
@rjbou rjbou moved this from PR finalised to PR to review in Opam 2.2.0 Dec 10, 2021
Opam 2.2.0 automation moved this from PR to review to PR finalised Jan 20, 2022
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjbou rjbou merged commit f70548b into ocaml:master Jan 21, 2022
Opam 2.2.0 automation moved this from PR finalised to Done Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

lockf issue on Windows
3 participants