Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of opam-lock with multiple interdependent packages #4993

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Fix handling of opam-lock with multiple interdependent packages #4993

merged 5 commits into from
Mar 4, 2022

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Jan 13, 2022

No description provided.

@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Jan 13, 2022
@rjbou rjbou added this to the 2.2.0~alpha milestone Jan 13, 2022
kit-ty-kate
kit-ty-kate reviewed Jan 13, 2022
View reviewed changes
src/client/opamLockCommand.ml Show resolved Hide resolved
src/client/opamLockCommand.ml Outdated Show resolved Hide resolved
@rjbou
Copy link
Collaborator

rjbou commented Jan 13, 2022

worth adding a test, see #4963

@AltGr
Copy link
Member Author

AltGr commented Jan 14, 2022

Ok @rjbou can I let you to take over on this one then ?

@kit-ty-kate kit-ty-kate mentioned this pull request Jan 19, 2022
Merged
Opam 2.2.0 automation moved this from PR in progress to PR finalised Jan 19, 2022
@rjbou rjbou moved this from PR finalised to PR in progress in Opam 2.2.0 Jan 20, 2022
@rjbou rjbou self-assigned this Jan 20, 2022
@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Mar 3, 2022
@rjbou rjbou moved this from PR in progress to PR finalised (merge with CI) in Opam 2.2.0 Mar 3, 2022
@rjbou rjbou added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Mar 3, 2022
@rjbou
Copy link
Collaborator

rjbou commented Mar 3, 2022

Added a test

@rjbou rjbou merged commit 0545fcd into ocaml:master Mar 4, 2022
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Mar 4, 2022
@rjbou
Copy link
Collaborator

rjbou commented Mar 4, 2022

Thanks!

@rjbou rjbou mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@rjbou rjbou rjbou approved these changes

Assignees

@rjbou rjbou

Labels
PR: QUEUED Pending pull request, waiting for other work to be merged or closed
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AltGr @rjbou @kit-ty-kate