Big speedup on reverse dependency calculation #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Indeed! I can confirm an almost 2x speedup on --depends-on + --recursive.
e.g. opam list --depends-on dune --recursive -s --all-versions take
- 9.4s before this PR
- 5.1s with this PR
And no difference in the result 🎉
No noticable difference could be obversed with non-recursive queries
kit-ty-kate
reviewed
Jan 18, 2022
|
All these |
|
Done in #5006 |
|
Test failure doesn't seem related to the PR 😕 |
kit-ty-kate
added
the
PR: QUEUED
We need to revert a huge simply-linked structure; the big cost was allocating the intermediate data, so instead of creating the graph or going through sets, we use the integer identifiers already defined by Cudf and store that in a simple table.
kit-ty-kate
force-pushed
the
fast-revdeps
branch
from
8980eff
to
9fdf7d4
Compare
kit-ty-kate
removed
the
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to revert a huge simply-linked structure; the big cost was allocating
the intermediate data, so instead of creating the graph or going through sets,
we use the integer identifiers already defined by Cudf and store that in a
simple table.