Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] document the options of OpamSolver.dependencies #5040

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

gasche
Copy link
Member

@gasche gasche commented Feb 3, 2022

This is a documentation-only PR: @Armael and myself were looking at OpamSolver.dependencis, and we did not know what the labelled argument were referring to. (We are still not fully sure that our documentation is correct.)

@kit-ty-kate kit-ty-kate added this to PR in progress in Opam 2.2.0 via automation Feb 3, 2022
@kit-ty-kate kit-ty-kate moved this from PR in progress to PR to review in Opam 2.2.0 Feb 3, 2022
@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Feb 3, 2022
@AltGr
Copy link
Member

AltGr commented Feb 4, 2022

[post]: include the dependencies of the post-install actions

it's actually like build: "include post dependencies" (ie dependencies flagged {post})

@AltGr
Copy link
Member

AltGr commented Feb 4, 2022

Otherwise all good, I meant to add 😅

@gasche
Copy link
Member Author

gasche commented Feb 4, 2022

Re "post": actually we started with just "include post dependencies", and we realized we didn't know what those were, so this is our best guess. I will make the proposed change. (In fact "post dependencies" are documented in the manual!)

gasche and others added 2 commits February 4, 2022 16:43
Co-authored-by: Armaël Guéneau <armael.gueneau@ens-lyon.org>
@gasche gasche force-pushed the document-OpamSolver.dependencies branch from 5e5d759 to e2b76d7 Compare February 4, 2022 15:44
@gasche
Copy link
Member Author

gasche commented Feb 4, 2022

@AltGr I pushed a new version, let me know what you think.

@kit-ty-kate kit-ty-kate moved this from PR to review to PR finalised (merge with CI) in Opam 2.2.0 Feb 4, 2022
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit c2c065a into ocaml:master Feb 9, 2022
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Feb 9, 2022
Out of release : doc, test, install, etc. automation moved this from PR to done Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants