Use the new menus for the initial setup too #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
AREA: UI
PR: QUEUED
|
|
rjbou
removed
the
PR: QUEUED
|
Updated! |
dra27
reviewed
May 18, 2022
Comment on lines
+787
to
+875
| let default = match env_hook with | ||
| | Some true -> `Yes | ||
| | Some false -> `No_hooks | ||
| | None -> `No | ||
| in |
There was a problem hiding this comment.
We can implement #4877 here:
Suggested change
| let default = match env_hook with | |
| | Some true -> `Yes | |
| | Some false -> `No_hooks | |
| | None -> `No | |
| in | |
| let default = if env_hook = Some false then `No_hooks else `Yes in |
rjbou
added
the
PR: QUEUED
rjbou
removed
the
PR: QUEUED
kit-ty-kate
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be rebased on top of #5053 which adds menu support