Fix lock behaviour with upgrade #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
the
PR: QUEUED
rjbou
commented
Mar 3, 2022
Merged
rjbou
removed
the
PR: QUEUED
rjbou
added
the
PR: QUEUED
AltGr
reviewed
Apr 19, 2022
rjbou
force-pushed
the
lock-upgrade
branch
2 times, most recently
from
66603d9
to
87c296a
Compare
rjbou
removed
the
PR: QUEUED
rjbou
force-pushed
the
lock-upgrade
branch
2 times, most recently
from
571ebb6
to
9db616d
Compare
…nd deprecated subdirectory
On more complex pin processes, lock files are not always handled (simulate pin, update on autopin, etc.)
This was referenced May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock files are ignored in the upgrade check / process
fix #4936
The issue was that there is no information about opam file origin. if it was a locked one, update & upgrade does their dependency computation according the regular opam file. The solution was to store the origin information (an
x-lockedfield in opam file, to not change its format), With that, update and upgrade are able to automatically update and upgrade from locked file if found if opam file originate from a lock file.In this PR also, there were some rework of pin types/functions.