Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Use gmake instead of make on Unix systems when available (fixes BSDs) #5090

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

kit-ty-kate
Copy link
Member

Without this, currently ./configure fails on *BSD because opam’s makefiles expect GNU Make.

I also took a few commits from #5049 to make it easy to modify on macOS

@kit-ty-kate kit-ty-kate added this to PR in progress in Opam 2.2.0 via automation Mar 7, 2022
@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Mar 7, 2022
@kit-ty-kate kit-ty-kate moved this from PR in progress to PR to review in Opam 2.2.0 Mar 7, 2022
@kit-ty-kate kit-ty-kate changed the title configure: Use gmake instead of make on Unix systems (fixes BSDs) configure: Use gmake instead of make on Unix systems when available (fixes BSDs) Mar 7, 2022
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We need to port these changes to #5055

@rjbou rjbou merged commit b1deeed into ocaml:master Mar 7, 2022
Opam 2.2.0 automation moved this from PR to review to Done Mar 7, 2022
rjbou added a commit to kit-ty-kate/opam that referenced this pull request May 12, 2023
configure: Use gmake instead of make on Unix systems when available (fixes BSDs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants