Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsonm and uutf dependencies #5098

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add jsonm and uutf dependencies #5098

merged 3 commits into from
Apr 1, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Mar 15, 2022 •
edited

They are helpful for json handling: for testing (and updating) json output and for SWHID request parsing (ftm it is done with regexp) #4859

fix #5085

@rjbou rjbou added this to the 2.2.0~alpha milestone Mar 15, 2022
@rjbou rjbou requested a review from dra27 March 15, 2022 16:47
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Mar 15, 2022
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Mar 15, 2022
kit-ty-kate
kit-ty-kate reviewed Mar 15, 2022
View reviewed changes
configure Outdated Show resolved Hide resolved
dra27
dra27 reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch for jsonm can only affect the lib-pkg build, so it would be in jsonm.pkg, rather than jsonm.common. However, it would seem easier just to add a dummy uchar package in the lib-pkg build - it's just a META file?

src_ext/dune-uutf-src Outdated Show resolved Hide resolved
opam-core.opam Outdated Show resolved Hide resolved
src/core/dune Outdated Show resolved Hide resolved
rjbou
rjbou commented Mar 31, 2022
View reviewed changes
opam-core.opam Outdated Show resolved Hide resolved
rjbou
rjbou commented Mar 31, 2022
View reviewed changes
src/core/dune Outdated Show resolved Hide resolved
rjbou
rjbou commented Mar 31, 2022
View reviewed changes
src_ext/dune-uutf-src Outdated Show resolved Hide resolved
dra27
dra27 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjbou rjbou merged commit 7116ccd into ocaml:master Apr 1, 2022
Opam 2.2.0 automation moved this from PR to review to Done Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
AREA: BUILD
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

Add json library
3 participants
@rjbou @kit-ty-kate @dra27