Silence w70 #5104
Merged
Silence w70 #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Mar 23, 2022
Comment on lines
19
to
+24
| ((action (run %{bin:cppo} -D "VERSION %{read-lines:version}" %{input-file})) opamVersion))) | ||
| (wrapped false)) | ||
|
|
||
| (rule | ||
| (copy opamStubsTypes.ml opamStubsTypes.mli)) | ||
|
|
There was a problem hiding this comment.
Suggested change
| ((action (run %{bin:cppo} -D "VERSION %{read-lines:version}" %{input-file})) opamVersion))) | |
| (wrapped false)) | |
| (rule | |
| (copy opamStubsTypes.ml opamStubsTypes.mli)) | |
| ((action (run %{bin:cppo} -D "VERSION %{read-lines:version}" %{input-file})) opamVersion))) | |
| (modules_without_implementation opamStubsTypes) | |
| (wrapped false)) | |
There was a problem hiding this comment.
I don't think that works - this is a module without an interface?
There was a problem hiding this comment.
ah right, then we just need to rename the files at the same time .ml --> .mli
There was a problem hiding this comment.
No - that's why I didn't... that changes the library and I didn't have the courage of my convictions to do that just to silence a warning 🙂
There was a problem hiding this comment.
(cf. the breakages in opam-file-format prior to 2.1.0!)
Comment on lines
15
to
+19
| (:include ../ocaml-context-flags.sexp))) | ||
| (wrapped false)) | ||
|
|
||
| (rule | ||
| (copy opamCudfSolverSig.ml opamCudfSolverSig.mli)) |
There was a problem hiding this comment.
Suggested change
| (:include ../ocaml-context-flags.sexp))) | |
| (wrapped false)) | |
| (rule | |
| (copy opamCudfSolverSig.ml opamCudfSolverSig.mli)) | |
| (:include ../ocaml-context-flags.sexp))) | |
| (modules_without_implementation opamCudfSolverSig) | |
| (wrapped false)) |
kit-ty-kate
approved these changes
Mar 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.