Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console menu: don't print special characters when output is not tty #5155

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Console menu: don't print special characters when output is not tty #5155

merged 2 commits into from
Jul 29, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented May 27, 2022

No description provided.

@rjbou rjbou added the AREA: UI label May 27, 2022
@rjbou rjbou added this to the 2.2.0~alpha milestone May 27, 2022
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation May 27, 2022
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 May 27, 2022
dra27
dra27 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some other things which confuse me about this function, but I expect that'll become clearer when I implement the Windows side of it... and the fix looks correct, regardless!

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 1ad4a9a into ocaml:master Jul 29, 2022
Opam 2.2.0 automation moved this from PR to review to Done Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
AREA: UI
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rjbou @kit-ty-kate @dra27