Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depext: improve check again routine #5157

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented May 27, 2022

  • Take into account not found packages instead of only available ones
  • Specify printed message
  • No more print system package manager helper if missing packages are only not found ones.

@rjbou rjbou added this to the 2.2.0~alpha milestone May 27, 2022
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation May 27, 2022
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 May 27, 2022
@kit-ty-kate
Copy link
Member

Conflicts in terms of idea with #5257

@rjbou
Copy link
Collaborator Author

rjbou commented Oct 13, 2022

as #5257 was reverted in favor to #5295, reconsidering it

…n still missing onesin order to check again.

When only not found ones are missing, it no more displays system package manager message/command
@rjbou rjbou moved this from PR to review to PR finalised (merge with CI) in Opam 2.2.0 Feb 8, 2023
@dra27 dra27 merged commit b0f5eae into ocaml:master Feb 8, 2023
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants