Make OpamConfigCommand.global_allowed_fields fully lazy #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it is not lazy, it causes other lazy values to be forced, notably `OpamStd.Env.list`. This is unexpected, and a bit of a problem for people using Opam as a library because they may want to set additional environment variables before callin Opam. Additionally, I'd expect this to be faster.
LasseBlaauwbroek
force-pushed
the
lazy-global-allowed
branch
from
e61a861
to
20dfaf2
Compare
kit-ty-kate
approved these changes
Jun 13, 2022
|
good for me! |
|
I have an OCaml program that uses Opam as a library to install a bunch of Coq packages and performs some benchmarks. Some of these Coq packages have Pip dependencies that are not explicitly listed in the Opam package. So I'm installing a separate Python virtualenv for them and adding the virtualenv to |
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it is not lazy, it causes other lazy values to be forced, notably
OpamStd.Env.list. This is unexpected, and a bit of a problem for people usingOpam as a library because they may want to set additional environment variables
before callin Opam.
Additionally, I'd expect this to be faster.