Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch import: fix installed packages reinstall when import file changed #5181

Merged
merged 4 commits into from
Jul 30, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jul 13, 2022

The check for reinstall of pinned packages is done at switch loading. Switch import change overlays afterwards, so a second check need to be done to mark changed one to reinstall before launching resolution.

@rjbou rjbou added this to the 2.2.0~alpha milestone Jul 13, 2022
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Jul 13, 2022
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Jul 13, 2022
@kit-ty-kate kit-ty-kate linked an issue Jul 13, 2022 that may be closed by this pull request
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small POSIX-erie, LGTM

tests/reftests/switch-import.test Outdated Show resolved Hide resolved
@rjbou rjbou moved this from PR to review to PR finalised (merge with CI) in Opam 2.2.0 Jul 15, 2022
@rjbou rjbou changed the title switch import: fix changed installed packages reinstall switch import: fix installed packages reinstall when import file changed Jul 19, 2022
@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit bffad07 into ocaml:master Jul 30, 2022
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Switch state sometimes needs to be imported twice to take effect.
2 participants