Overhaul the Windows C stubs and update them for Unicode #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
the
PR: QUEUED
opam-core already requires OCaml 4.06+ for the Unicode functions.
SendMessageTimeout and the process injection are potentially more expensive system calls.
OCaml 4.06 is already the minimum required version, so process UTF-8 correctly in the system calls.
rjbou
removed
the
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly easier seen commit-by-commit. This PR:
#ifdef _WIN32caml_string_is_c_safe(this is a guard which stops OCaml strings containing\0from being passed to C functions which expect null-terminated strings) and releasing the runtime lock on a couple of longer-lived functionsFinally, the main focus is to switch the PR to use Unicode properly, in particular for the environment stubs implementation.