Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the reason for installing packages when using opam reinstall #5229

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Show the reason for installing packages when using opam reinstall #5229

merged 2 commits into from
Nov 9, 2022

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Aug 5, 2022 •
edited

Fixes #5227

TODO:

  • Some tests should be added to prevent regressions

@kit-ty-kate kit-ty-kate added KIND: BUG AREA: SOLVER PR: WIP Not for merge at this stage labels Aug 5, 2022
AltGr
AltGr approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@AltGr AltGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this might also change behaviour with e.g. with-test flags in the package files; but this is a fix in this case as well!

@kit-ty-kate kit-ty-kate added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: WIP Not for merge at this stage labels Nov 8, 2022
@kit-ty-kate
Copy link
Member Author

Queued on top of #5228

@kit-ty-kate kit-ty-kate force-pushed the fix-reason-reinstall branch 2 times, most recently from 03bcbd7 to b9df0a6 Compare November 8, 2022 20:07
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Nov 8, 2022
rjbou
rjbou approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Nov 9, 2022
@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 9, 2022
@kit-ty-kate kit-ty-kate merged commit af4d284 into ocaml:master Nov 9, 2022
Opam 2.2.0 automation moved this from PR in progress to Done Nov 9, 2022
@kit-ty-kate kit-ty-kate deleted the fix-reason-reinstall branch November 9, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltGr AltGr AltGr approved these changes

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
AREA: SOLVER KIND: BUG
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

opam reinstall does not show the reason for installing packages
3 participants
@kit-ty-kate @AltGr @rjbou