Fix --best-effort regression introduced in #4975 #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Aug 26, 2022
kit-ty-kate
approved these changes
Aug 26, 2022
|
(I'm not familiar with the testing code so if someone else wants to do that I'd be grateful) |
Could you provide a rough test-case (rough steps, something that fails in your case) so we can try add it to the reftests on our side? |
|
The test from #4796 |
kit-ty-kate
added a commit
to LasseBlaauwbroek/opam
that referenced
this pull request
Aug 31, 2022
…ying to install specific versions of packages See ocaml#5261
kit-ty-kate
force-pushed
the
refix-best-effort
branch
from
87dc9a2
to
affdf44
Compare
…ying to install specific versions of packages See ocaml#5261
In PR ocaml#4796 I fixed a problem with `--best-effort`. Subsequently ocaml#4975 seems to have broken this again. Not sure if this is the correct fix. There may also be additional places where this is going wrong...
kit-ty-kate
force-pushed
the
refix-best-effort
branch
from
affdf44
to
b02f437
Compare
kit-ty-kate
reviewed
Aug 31, 2022
kit-ty-kate
added
KIND: BUG
PR: WIP
|
Thanks a lot! |
Leonidas-from-XIV
pushed a commit
to Leonidas-from-XIV/opam
that referenced
this pull request
Mar 10, 2023
…ying to install specific versions of packages See ocaml#5261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #4796 I fixed a problem with
--best-effort. Subsequently #4975 seems tohave broken this again. Not sure if this is the correct fix. There may also be
additional places where this is going wrong...