Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reftest: add path replacement command command #5285

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Sep 15, 2022

Command are resolved in opam, which leads to some full path printing. Add sed-cmd command to help this rewrite.

-### opam install ongoing -v | '.*(/|\\|")test(\.exe)?"? "' -> 'test "' 
+### opam install ongoing -v | sed-cmd test

@rjbou rjbou added this to the 2.2.0~alpha milestone Sep 15, 2022
@rjbou rjbou added this to PR in Out of release : doc, test, install, etc. via automation Sep 15, 2022
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Sep 15, 2022
@@ -413,6 +415,20 @@ module Parse = struct
get_rewr (unordered, (posix_re re, Grep) :: acc) r
| "|" :: "unordered" :: r ->
get_rewr (true, acc) r
| "|" :: "sed-cmd" :: cmd :: r ->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the name, any ideas ?

@kit-ty-kate kit-ty-kate merged commit 8b09027 into ocaml:master Sep 20, 2022
Opam 2.2.0 automation moved this from PR in progress to Done Sep 20, 2022
Out of release : doc, test, install, etc. automation moved this from PR to done Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants