Fix mangling of PATH during cygvoke
#5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PATH is manipulated as part of the call to execve when invoking Cygwin binaries, but the function didn't parse the first element of PATH correctly.
kit-ty-kate
approved these changes
Sep 21, 2022
rjbou
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling Cygwin binaries, the process invocation manipulates
PATHto ensure that Cygwin'sbindirectory appears before the Windowssystem32directory to ensure that Cygwin binaries don't unexpectedly start using Window's BSD executables (a normal Cygwin shell avoids this by forcibly putting/usr/binat the beginning ofPATH).Unfortunately, I made a slight mistake with the first entry - it's an environment block string, so the first entry is
PATH=<dir>and thePATH=part wasn't split off.This PR corrects that; therapy will deal with the fact that I discovered this quite old bug the night before a demo...