Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fgrep with grep -F #5309

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Replace fgrep with grep -F #5309

merged 1 commit into from
Oct 11, 2022

Conversation

MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Oct 10, 2022

The egrep and fgrep commands, which have been deprecated since release 2.5.3 (2007), now warn that they are obsolescent and should be replaced by grep -E and grep -F.

https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html

@rjbou rjbou requested a review from dra27 October 10, 2022 08:49
master_changes.md Outdated Show resolved Hide resolved
@dra27
Copy link
Member

dra27 commented Oct 11, 2022

LGTM, thanks, and should be applied to 2.0 and 2.1. RIP fgrep and egrep

> The egrep and fgrep commands, which have been deprecated since
> release 2.5.3 (2007), now warn that they are obsolescent and should
> be replaced by grep -E and grep -F.

https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html

Signed-off-by: Antonin Décimo <antonin@tarides.com>
@rjbou rjbou added this to PR in Progress in Opam 2.1.x via automation Oct 11, 2022
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Oct 11, 2022
@rjbou rjbou added this to the 2.2.0~alpha milestone Oct 11, 2022
@rjbou rjbou merged commit dc69c4b into ocaml:master Oct 11, 2022
Opam 2.1.x automation moved this from PR in Progress to Done Oct 11, 2022
Opam 2.2.0 automation moved this from PR in progress to Done Oct 11, 2022
@rjbou
Copy link
Collaborator

rjbou commented Oct 11, 2022

thanks!

@MisterDA MisterDA deleted the fgrep branch October 11, 2022 12:58
@MisterDA
Copy link
Contributor Author

BTW I checked and there were no uses of egrep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.1.x
  
Done
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants