Allow opam pin remove to take a package as argument #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
reviewed
Oct 21, 2022
kit-ty-kate
force-pushed
the
unpin-version
branch
2 times, most recently
from
d977e46
to
f97d1ab
Compare
kit-ty-kate
commented
Oct 21, 2022
kit-ty-kate
force-pushed
the
unpin-version
branch
from
f97d1ab
to
d18ec65
Compare
rjbou
approved these changes
Oct 21, 2022
kit-ty-kate
force-pushed
the
unpin-version
branch
2 times, most recently
from
a97e22b
to
0c7e474
Compare
kit-ty-kate
force-pushed
the
unpin-version
branch
from
0c7e474
to
f1d6646
Compare
rjbou
reviewed
Oct 31, 2022
kit-ty-kate
force-pushed
the
unpin-version
branch
from
f1d6646
to
6ce1228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
opam pin listreturns something of the form:However users often simply expect that selecting the first column (
<pkg>.<version>), done very simply by double-clicking on the name on the terminal, to unpin the package would work. However doing this will end up in a rather surprising failure:This PR removes this surprising restriction