Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use List function with comparison functions #5374

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Dec 1, 2022

To avoid using polymorphic ones.
This PR is the first of more cleaning in code about polymorphic comparison usage

src/format/opamFile.ml Outdated Show resolved Hide resolved
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Feb 6, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone Feb 6, 2023
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monomorphic joy! LGTM

@dra27 dra27 moved this from PR in progress to PR finalised (merge with CI) in Opam 2.2.0 Feb 6, 2023
@dra27 dra27 merged commit 3c2f384 into ocaml:master Feb 7, 2023
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants