Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable siz #5403

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

purplearmadillo77
Copy link
Contributor

When compiling opam (most recent git) with GCC 11.3.0 on Cygwin64, I get the following error when developer mode is enabled (and NOT during normal compilation since -Werror is only activated in developer mode):

File "src/stubs/libacl/dune", line 12, characters 19-26:
12 |     (names         opamACL)
                        ^^^^^^^
opamACL.c: In function ‘OPAM_get_acl_executable_info’:
opamACL.c:44:12: error: unused variable ‘siz’ [-Werror=unused-variable]
   44 |     size_t siz;
      |            ^~~
cc1: all warnings being treated as errors
make: *** [Makefile:144: build-opam] Error 1

It doesn’t seem like the siz variable is used at all in this file, so I’ve removed it.

Additionally, I wasn't sure which category this would fall under in the changes file - I've currently put it under "Build" since the above was a building problem.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Section for master_changes is just fine - would you be able to re-push with the PR number?

@kit-ty-kate
Copy link
Member

Thanks! Section for master_changes is just fine - would you be able to re-push with the PR number?

I've done it for them. It's easier and faster this way.

@purplearmadillo77
Copy link
Contributor Author

Thank you! I'll add the PR number in the future.

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit 56a3a15 into ocaml:master Jan 4, 2023
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Mar 11, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone Mar 11, 2023
@rjbou rjbou moved this from PR in progress to Done in Opam 2.2.0 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants