Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "opam list -s --coinstallable-with pkg.1 pkg.2" listing pkg.2 as coinstallable with pkg.1 #5414

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

kit-ty-kate
Copy link
Member

Fix #5399

@kit-ty-kate kit-ty-kate force-pushed the fix-opam-list-coinstallable branch 2 times, most recently from b06543d to 897a5ee Compare January 11, 2023 21:26
@@ -0,0 +1,7449 @@
697eab693df71fb665a546e779348a9a823dea2c
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One weird thing here is that I've tried to use other hashes but they weren't able to show the same behaviour :/ @AltGr do you have any idea why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind i found a way. It must've been something that made opam-0install.0.4.2 unavailable with ocaml/opam-repository@7371c1d9 (this behaviour of opam list --coinstallable-with is quite surprising and annoying to work with)

…" listing pkg.2 as coinstallable with pkg.1

Shows the behaviour described in ocaml#5399
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dra27 dra27 merged commit a9033bf into ocaml:master Jan 17, 2023
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Mar 11, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone Mar 11, 2023
@rjbou rjbou moved this from PR in progress to Done in Opam 2.2.0 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

"opam list --recursive --coinstallable-with <pkg>.<version>" returns all versions of <pkg>
3 participants