Enforce extra-source to have a checksum when using "opam switch export --freeze" #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when checksums are missing
kit-ty-kate
force-pushed
the
extra-source-freeze
branch
from
c67e6ae
to
c373818
Compare
kit-ty-kate
force-pushed
the
extra-source-freeze
branch
from
c373818
to
0f08c70
Compare
|
looks great to me. |
rjbou
approved these changes
Feb 15, 2023
|
lgtm, & thanks for the withespace tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze-exporting packages that have extra-sources without any checksum shouldn't be allowed. This PR fixes this bug.
Side note for reviewers: you can see the diff better using github's "hide whitespace" option