Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the macOS sandbox script to use /bin/bash instead of /usr/bin/env bash for a more consistent experience #5451

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

kit-ty-kate
Copy link
Member

For most users this is strictly equivalent, however in some cases another (possibly broken) bash could be installed and used instead.

Fixes #5450

@dra27
Copy link
Member

dra27 commented Feb 27, 2023

This PR changes the Linux script at the moment - it's sandbox_exec.sh for macOS?

@kit-ty-kate
Copy link
Member Author

This PR changes the Linux script at the moment - it's sandbox_exec.sh for macOS?

oops 😅. Fixed now.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for an extra comment just to avoid the risk of this being regressed by any shell-checking!

src/state/shellscripts/sandbox_exec.sh Show resolved Hide resolved
…bin/bash

Co-authored-by: David Allsopp <david.allsopp@metastack.com>
@dra27 dra27 merged commit 1762a4e into ocaml:master Mar 6, 2023
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Mar 11, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone Mar 11, 2023
@rjbou rjbou moved this from PR in progress to Done in Opam 2.2.0 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

opam does not compile packages to ARM arch on macOS
3 participants