Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some windows shell updates #5541

Merged
merged 12 commits into from
Jun 15, 2023
Merged

Some windows shell updates #5541

merged 12 commits into from
Jun 15, 2023

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented May 8, 2023

This PR is a subset of #5220

@rjbou rjbou force-pushed the more-windows-shell branch 3 times, most recently from 9444b32 to 10b6d88 Compare May 10, 2023 20:23
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation May 11, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone May 11, 2023
@rjbou rjbou moved this from PR in progress to PR to review for 2.2.0~alpha in Opam 2.2.0 May 11, 2023
dra27 added 12 commits June 12, 2023 13:37
It has a Wikipedia page and everything!
The old DOS style - curiously - is used in the command descriptions and
then all the examples use lowercase (as do most shell scripts written
these days).
The PowerShell implementation isn't yet correct and the Command
Processor will never have one. Refactor the code to skip .profile files
for those.
Read the entire process ancestry in a single snapshot and then return
the full image names to opam. This makes the shell analysis slightly
more efficient. The full image paths rather than just the executable
names pave the way for opam to be able to initialise PowerShell
properly.
@rjbou rjbou moved this from PR to review for 2.2.0~alpha to PR finalised (merge with CI) in Opam 2.2.0 Jun 12, 2023
@rjbou rjbou merged commit 469cc40 into ocaml:master Jun 15, 2023
26 checks passed
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done Jun 15, 2023
@rjbou rjbou mentioned this pull request Jun 15, 2023
16 tasks
@dra27 dra27 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants