init: install cygwin internally #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
4 tasks
rjbou
force-pushed
the
cygwin-internal-install
branch
from
0d12eab
to
cf861fc
Compare
AltGr
approved these changes
Jun 12, 2023
| let required_packages_for_cygwin = | ||
| [ | ||
| "diffutils"; | ||
| "git"; (* XXX hg & mercurial ? *) |
There was a problem hiding this comment.
Those are so little used nowadays that we shouldn't bother with them by default
rjbou
moved this from PR to review for 2.2.0~alpha
to After ~alpha; before release
in Opam 2.2.0
rjbou
moved this from After ~alpha; before release
to PR to update for alpha2
in Opam 2.2.0
rjbou
force-pushed
the
cygwin-internal-install
branch
from
cf861fc
to
83338d3
Compare
rjbou
removed
the
PR: QUEUED
rjbou
commented
Jul 18, 2023
src/client/opamCommands.ml
Outdated
Comment on lines
306
to
329
| let cygwin_internal = | ||
| mk_vflag ~cli `none [ | ||
| cli_from cli2_2, `internal, ["cygwin-internal-install"], | ||
| "Let opam setup and manage an internal Cygwin install"; | ||
| cli_from cli2_2, `default_location, ["cygwin-local-install"], | ||
| "Use preexistent Cygwin install"; | ||
| cli_from cli2_2, `no, ["no-cygwin-setup"], | ||
| "Don't setup Cygwin"; | ||
| ] | ||
| in | ||
| let cygwin_location = | ||
| mk_opt ~cli (cli_from cli2_2) ["cygwin-location"] "DIR" | ||
| "Specify Cygwin root location" | ||
| Arg.(some dirname) None | ||
| in |
There was a problem hiding this comment.
Other proposal: --cygwin [no|internal|default|<location>]
There was a problem hiding this comment.
Hm I like the proposal (but it's ok as is)
There was a problem hiding this comment.
Additional question: do we make sure that the cygwin option don't show up on other OSes ?
kit-ty-kate
reviewed
Jul 18, 2023
kit-ty-kate
approved these changes
Jul 18, 2023
rjbou
force-pushed
the
cygwin-internal-install
branch
from
29e4c17
to
66ba38f
Compare
* --cygwin-internal: setup internal cygwin install * --cygwin-install: use local install, default is C:\cygwin64 * --cygwin-location: specify cygwin root path * --no-cygwin-setup: don't setup cygwin in opam
rjbou
force-pushed
the
cygwin-internal-install
branch
from
c7e38eb
to
2858c2e
Compare
rjbou
moved this from PR to review for alpha2
to PR finalised (merge with CI)
in Opam 2.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At init, add an item in the cygwin menu to propose to have a cygwin install internal to opam. It is handled by opam itself (prefix stored in
<opamroot>/.cygwin/root), when depext are requested, there is no confirmation requested.It also adds some flags to
init, to have a cywgin configuration non interactively:--no-cygwin-setup|--cygwin-internal-install|--cygwin-local-installand--cygwin-location <path>.These are experimental as they can change name from the finale release.
TODO