Return the retrieved checksums on failure #5552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change it was not possible to get the actual checksum from the API, because OPAM would download the file, compare checksums, emit an error message and delete the file with the wrong checksum. So to be able to get the actual checksum, one needed to disable the validation and reimplement the validation on top of the unvalidated API call. This PR returns the invalid checksums.
|
Out of curiosity, why would you want to keep the retrieved checksum on a failure? Adding various |
|
@hannesm If can be useful if you know you're expecting the checksum to change. E.g. you have a checksum specified, then deliberately change the tarball, then whoever is retrieving it using this API can tell you "hey, the checksum changed, is this deliberate? If so, I can actually also update the expected checksum to match". A bit like the promotion mechanism in Dune, you can of course edit the files manually, but if the change is expected, why not let the computer do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change it was not possible to get the actual checksum from the API, because OPAM would download the file, compare checksums, emit an error message and delete the file with the wrong checksum.
So to be able to get the actual checksum, one needed to disable the validation and reimplement the validation on top of the unvalidated API call. This PR returns the invalid checksums.