source: add --no-checksums & --require-checksums flags
#5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
the
PR: QUEUED
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: QUEUED
AltGr
approved these changes
Sep 7, 2023
src/client/opamCommands.ml
Outdated
| mk_flag ~cli (cli_from cli2_2) ["require-checksums"] | ||
| "Enforce checksum verification befor downloading sources.\ | ||
| This is equivalent to setting $(b,\\$OPAMREQUIRECHECKSUMS) to \"true\"." | ||
| in |
There was a problem hiding this comment.
might be worth sharing the flags definitions with the ones used in OpamArg.build_options ? (maybe that was too tedious to be worth it, in that case it's alright)
There was a problem hiding this comment.
|
Appreciated, and this looks great to me. As @AltGr mentioned, it may be useful to share some code. Thanks a lot. |
…he counterpart of that is that we loose the fact that the newly effective options (in opam source for ex) are not flaggued as new in cli 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @hannesm @reynir