reftest: update commands prefix replacement #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
commented
Sep 8, 2023
tests/reftests/run.ml
Outdated
| *) | ||
| seq [ | ||
| opt @@ char '"'; | ||
| repn @@ seq [ char '/'; repn @@ diff any (alt [ space; char '/']) ]; |
There was a problem hiding this comment.
It relies on no space on command full path
There was a problem hiding this comment.
you should probably exclude " and ' as well
AltGr
reviewed
Sep 8, 2023
tests/reftests/run.ml
Outdated
| *) | ||
| seq [ | ||
| opt @@ char '"'; | ||
| repn @@ seq [ char '/'; repn @@ diff any (alt [ space; char '/']) ]; |
There was a problem hiding this comment.
you should probably exclude " and ' as well
kit-ty-kate
approved these changes
Sep 11, 2023
rjbou
force-pushed
the
reftest-sed-cmd
branch
from
abbdc5c
to
c066e38
Compare
Now it handles sandbox prefix, and command prefixes that are not a print of a subprocess (in an error message for ex).
rjbou
force-pushed
the
reftest-sed-cmd
branch
from
c066e38
to
1f89515
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it handles sandbox prefix, and command prefixes that are not a print of a subprocess (in an error message for ex).