OPAMVERBOSE: Fix level by flipping the env_level implementation
#5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not sure where to put this PR in the changelog. |
rjbou
force-pushed
the
fix-env-level
branch
from
6c88853
to
c82f2d5
Compare
rjbou
changed the title
level by flipping the env_level implementationlevel by flipping the env_level implementation
|
Well spotted! I've updated the PR with some tests & filled changes. Thanks! |
rjbou
approved these changes
Sep 25, 2023
rjbou
force-pushed
the
fix-env-level
branch
from
c82f2d5
to
1fa9e75
Compare
Signed-off-by: Sora Morimoto <sora@morimoto.io>
rjbou
force-pushed
the
fix-env-level
branch
from
1fa9e75
to
0cdece6
Compare
|
Thanks! |
|
Likewise! |
rjbou
added a commit
to rjbou/opam
that referenced
this pull request
Oct 16, 2023
OPAMVERBOSE: Fix `level` by flipping the `env_level` implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This literally flips the implementation. As you can see in the implementation of
bool_of_string, the original implementation does not seem correct.opam/src/core/opamStd.ml
Lines 1666 to 1670 in b0cb137
In fact, I found this when debugging a GitHub Actions issue, and you can easily reproduce the issue on your machine by just try each of the following commands: