Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ACL in Cygwin to avoid permission missmatch errors #5796

Merged
merged 1 commit into from Feb 16, 2024
Merged

Disable ACL in Cygwin to avoid permission missmatch errors #5796

merged 1 commit into from Feb 16, 2024

Conversation

kit-ty-kate
Copy link
Member

Fixes #5781

@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta2 milestone Jan 22, 2024
@kit-ty-kate kit-ty-kate added this to For beta2 in Opam 2.2.0 Jan 22, 2024
@dra27
Copy link
Member

dra27 commented Feb 5, 2024

In the grand scheme of the amount of work going on in opam init, the time overhead is low, but I think it would be better to use OCaml to read the text file and update that line with a ocaml-re, rather than shelling out to sed (the cost of the Cygwin shell invocations in the eval-variables is perceptible, for example, when running opam config list)

@kit-ty-kate kit-ty-kate marked this pull request as ready for review February 5, 2024 20:01
@kit-ty-kate
Copy link
Member Author

@dra27 done

@dra27
Copy link
Member

dra27 commented Feb 15, 2024

Looks good, thanks! I just pushed a tweak to open the file using native paths. @rjbou - LGTY?

rjbou
rjbou approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

master_changes.md Outdated Show resolved Hide resolved
@kit-ty-kate @dra27
Disable ACL in Cygwin to avoid permission missmatch errors
6306718 
Co-authored-by: David Allsopp <david.allsopp@metastack.com>
@kit-ty-kate kit-ty-kate merged commit 25560b4 into ocaml:master Feb 16, 2024
39 checks passed
Opam 2.2.0 automation moved this from For beta2 to Done Feb 16, 2024
@kit-ty-kate kit-ty-kate deleted the set-noacl-cygwin branch February 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
AREA: PORTABILITY
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~beta2
Development

Successfully merging this pull request may close these issues.

Cygwin internal installation should set noacl in /etc/fstab for /cygdrive mount
3 participants
@kit-ty-kate @dra27 @rjbou