arg: fix loading git location from config file at init #5842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what does this section of code do? Could you write a small description of the issue too? |
|
Comment updated! |
kit-ty-kate
approved these changes
Feb 16, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cygwin support added the need to retrieve some information (cygwin binary path) from the config file before its proper loading by the global state (see https://github.com/ocaml/opam/pull/5544/files#diff-e674376a5ba688da9b6f11571be146af2e7bbde7c583630c6e8d4fc15c575035R575).
Git on windows PR #5718 used the same mechanism to load git location information at an early stage.
This PR fixes that retrieval implemented in #5718:
git-locationwas searched amongglobal-variablesvariables, not among field as implemented in this PR.