Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump src_ext versions and patch Dune #5871

Closed
wants to merge 4 commits into from
Closed

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Mar 5, 2024

This should be a temporary fix for #5861, until Dune 3.14.1 is released.

The script only scanned src_ext/Makefile.sources. Trivial refactoring to
scan and update packages in both files.
@kit-ty-kate
Copy link
Member

kit-ty-kate commented Mar 5, 2024

We seemed to have duplicated some work between this PR and #5869 (and the subsequent PR for 3.14.1 i had ready). It looks like dune 3.14.1 is going to be released pretty soon so the patch might be obsolete quite quickly.
If it is released before we merge all the other blockers for 2.2.0~beta2 i'd personally rather go with the patch-less approach

@dra27
Copy link
Member Author

dra27 commented Mar 5, 2024

Oo, that's very silly of me - sorry! There are some bits of this one that are worth combining with yours (the not-strictly-related .gitignore part and the update to the other src_exts).

Let's see whether it becomes moot, but I disagree with the patch - I think it's better to have an inspectable patch in the repo (just as we used to) rather than a pointer a specific sha elsewhere.

@kit-ty-kate
Copy link
Member

Let's see whether it becomes moot, but I disagree with the patch - I think it's better to have an inspectable patch in the repo (just as we used to) rather than a pointer a specific sha elsewhere.

oh no i agree with that. What i meant is that if dune 3.14.1 releases like tomorrow or something it would be better to use that instead directly

@dra27
Copy link
Member Author

dra27 commented Mar 6, 2024

Ohhhh 🤦‍♂️ Yes, we were arguing in total agreement 🙂

@dra27
Copy link
Member Author

dra27 commented Mar 11, 2024

This is all merged in #5869 or will be fixed in Dune 3.14.1

@dra27 dra27 closed this Mar 11, 2024
Opam 2.2.0 automation moved this from For beta2 to Done Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants