Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: add missing 'since opam 2.2' annotation when mentionning with-dev-setup #5885

Merged
merged 1 commit into from Mar 19, 2024

Conversation

kit-ty-kate
Copy link
Member

No description provided.

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In the manual, there was no specification of since xx for newly added features or fields. It was like that as there was the separation between documentation for 1.2, 2.0, 2.1 in the menu. But it is no more done, and master is the one deployed, which can be confusing for users.
We should do a whole review of the doc to put since xxx everywhere it is required. The current status (mix of some previous changes that introduced some since xxx and other without it) can confuse the reader that everything that is not annotated is always present/working (2.0 & 2.1 compliant).

@kit-ty-kate kit-ty-kate added this to For beta2 in Opam 2.2.0 Mar 19, 2024
@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta2 milestone Mar 19, 2024
@kit-ty-kate kit-ty-kate merged commit c6d3bb2 into ocaml:master Mar 19, 2024
2 checks passed
Opam 2.2.0 automation moved this from For beta2 to Done Mar 19, 2024
Out of release : doc, test, install, etc. automation moved this from PR to done Mar 19, 2024
@kit-ty-kate kit-ty-kate deleted the doc-with-dev-setup-since-2.2 branch March 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants