Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Software Heritage fallbacks by default #5899

Merged
merged 1 commit into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions master_changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ users)
## Show

## Var/Option
* Disable Software Heritage fallbacks by default [#5899 @kit-ty-kate]

## Update / Upgrade

Expand Down
2 changes: 1 addition & 1 deletion src/format/opamFile.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ module ConfigSyntax = struct
depext_bypass = OpamSysPkg.Set.empty;
sys_pkg_manager_cmd = OpamStd.String.Map.empty;
git_location = None;
swh_fallback = true;
swh_fallback = false;
}

(* When adding a field, make sure to add it in
Expand Down
6 changes: 3 additions & 3 deletions tests/reftests/init.test
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ eval-variables: [[sys-ocaml-version ["ocamlc" "-vnum"] "OCaml version present on
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
wrap-remove-commands: ["%{hooks}%/sandbox.sh" "remove"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -189,7 +189,7 @@ solver: "a-solver"
solver-criteria: "solver-criteri"
solver-fixup-criteria: "fixup-criteri"
solver-upgrade-criteria: "upgrade-criteri"
swh-fallback: true
swh-fallback: false
wrap-build-commands: ["%{hooks}%/a-script.sh" "wrap-build"]
wrap-install-commands: ["%{hooks}%/a-script.sh" "wrap-install"]
wrap-remove-commands: ["%{hooks}%/a-script.sh" "wrap-remove"]
Expand Down Expand Up @@ -243,7 +243,7 @@ opam-version: "2.0"
post-session-commands: ["%{hooks}%/a-script.sh" "post-session"]
pre-build-commands: ["%{hooks}%/a-script.sh" "pre-build"]
repositories: "norepo"
swh-fallback: true
swh-fallback: false
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/a-script.sh" "wrap-install"]
wrap-remove-commands: ["%{hooks}%/sandbox.sh" "remove"] {os = "linux" | os = "macos"}
Expand Down
60 changes: 30 additions & 30 deletions tests/reftests/opamroot-versions.test
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ installed-switches: ["sw-comp" "sw-sys-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -835,7 +835,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -916,7 +916,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -983,7 +983,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -1050,7 +1050,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1125,7 +1125,7 @@ installed-switches: ["sw-comp" "sw-sys-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1197,7 +1197,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "${BASEDIR}" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1272,7 +1272,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1341,7 +1341,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -1411,7 +1411,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1489,7 +1489,7 @@ installed-switches: ["sw-comp" "sw-sys-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1563,7 +1563,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "${BASEDIR}" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1640,7 +1640,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1709,7 +1709,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -1779,7 +1779,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -1849,7 +1849,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -1920,7 +1920,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -1993,7 +1993,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2054,7 +2054,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2115,7 +2115,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -2196,7 +2196,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2266,7 +2266,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2338,7 +2338,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2410,7 +2410,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2455,7 +2455,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default"]
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down Expand Up @@ -2537,7 +2537,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2597,7 +2597,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2657,7 +2657,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2718,7 +2718,7 @@ jobs: 4
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
### opam-cat $OPAMROOT/repo/repos-config
opam-version: "2.0"
Expand Down Expand Up @@ -2756,7 +2756,7 @@ installed-switches: ["sw-sys-comp" "sw-comp" "default" "${BASEDIR}/why-did-you-d
opam-root-version: current
opam-version: "2.0"
repositories: "default"
swh-fallback: true
swh-fallback: false
switch: "sw-sys-comp"
wrap-build-commands: ["%{hooks}%/sandbox.sh" "build"] {os = "linux" | os = "macos"}
wrap-install-commands: ["%{hooks}%/sandbox.sh" "install"] {os = "linux" | os = "macos"}
Expand Down
2 changes: 1 addition & 1 deletion tests/reftests/swhid.unix.test
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ url {
mirrors: "https://swhid.opam.ocaml.org/swh:1:dir:9f2be900491e1dabfc027848204ae01aa88fc71d"
}
### opam option swh-fallback=false
Set to 'false' the field swh-fallback in global configuration
No modification in global configuration
### opam install snappy-swhid-dir -v | '"/.*curl' -> '"curl' | "${OPAMVERSION}" -> "current"
The following actions will be performed:
=== install 1 package
Expand Down
6 changes: 3 additions & 3 deletions tests/reftests/var-option.test
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ solver {}
solver-criteria {}
solver-fixup-criteria {}
solver-upgrade-criteria {}
swh-fallback true
swh-fallback false
sys-pkg-manager-cmd {}
wrap-build-commands {}
wrap-install-commands {}
Expand Down Expand Up @@ -627,7 +627,7 @@ solver {}
solver-criteria {}
solver-fixup-criteria {}
solver-upgrade-criteria {}
swh-fallback true
swh-fallback false
sys-pkg-manager-cmd {}
wrap-build-commands {}
wrap-install-commands {}
Expand Down Expand Up @@ -659,7 +659,7 @@ solver {}
solver-criteria {}
solver-fixup-criteria {}
solver-upgrade-criteria {}
swh-fallback true
swh-fallback false
sys-pkg-manager-cmd {}
wrap-build-commands {}
wrap-install-commands {}
Expand Down